feat(storage): update storage API options to include bucket #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
phantum/storage_multiple_services
to
feature/storage_multi-bucket_support
August 15, 2024 20:18
6 tasks
mattcreaser
reviewed
Aug 20, 2024
aws-storage-s3/src/test/java/com/amplifyframework/storage/s3/AWSS3StoragePluginTest.kt
Outdated
Show resolved
Hide resolved
mattcreaser
approved these changes
Aug 20, 2024
6 tasks
lawmicha
approved these changes
Aug 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-bucket support part 2
This the second part of a series of changes/pull request to support multi-bucket in the S3 Storage Plugin. The series of changes will be reviewed and merged into a feature branch and combined into a single pull request to be reviewed and merged into main branch.
part 1: #2895
Issue #, if available:
Description of changes:
Updated Storage plugin api options in
com.amplifyframework.storage.optionsto support specifyingStorageBucket.Integration test will be added in a separate followup PR (chore(storage): add integration tests for multi-bucket support #2900)
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
Added Integration TestsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.